Skip to content

add support for sealed response interfaces for spring-declarative-http-interface#23549

Open
tempacc21 wants to merge 1 commit intoOpenAPITools:masterfrom
tempacc21:master
Open

add support for sealed response interfaces for spring-declarative-http-interface#23549
tempacc21 wants to merge 1 commit intoOpenAPITools:masterfrom
tempacc21:master

Conversation

@tempacc21
Copy link
Copy Markdown

@tempacc21 tempacc21 commented Apr 15, 2026

fixes #23548

#23003 Added support for sealed response interfaces, but it is not supported for spring-declarative-http-interface

This PR adds support for it. I had some trouble running the mvnw clean package command locally on my mac, but KotlinSpringServerCodegenTest passes

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Adds sealed response interface support to Kotlin Spring spring-declarative-http-interface when useSealedResponseInterfaces is enabled, so generated APIs can return sealed interfaces instead of concrete models. Fixes #23548.

  • New Features
    • Applies vendorExtensions.x-sealed-response-interface to return types for maps, arrays, and single results, with or without ResponseEntity, Reactor, or coroutines.
    • Adds a generator test validating ResponseEntity<CreateUserResponse> and ResponseEntity<GetUserResponse> outputs.

Written for commit 599f102. Summary will update on new commits.

@tempacc21
Copy link
Copy Markdown
Author

Hey, would love a review @karismann @Zomzog @andrewemery @4brunu @stefankoppier @e5l @dennisameling

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

@wing328 wing328 added this to the 7.22.0 milestone Apr 15, 2026
tempacc21 added a commit to tempacc21/openapi-generator-bazel that referenced this pull request Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [kotlin-spring] sealed interfaces not supported by spring-declarative-http-interface

2 participants