Skip to content

[C] Update README and adding object.c/h files#2377

Merged
wing328 merged 3 commits intoOpenAPITools:masterfrom
zhemant:issuecgen
Mar 19, 2019
Merged

[C] Update README and adding object.c/h files#2377
wing328 merged 3 commits intoOpenAPITools:masterfrom
zhemant:issuecgen

Conversation

@zhemant
Copy link
Contributor

@zhemant zhemant commented Mar 12, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

  • update handling of reserved keywords to make it same in all cases
  • update README mustache to give info about how to compile the library and use the library
  • add object header and body mustache to create object models
  • set isEnum which is required for handling enum variables in C codegen in CLibCurlClientCodegen.java to avoid conflict with other codegen

cc
@wing328

@zhemant zhemant changed the title Update README and adding object.c/h files [C] Update README and adding object.c/h files Mar 13, 2019
@wing328
Copy link
Member

wing328 commented Mar 14, 2019

@zhemant can you please rebase this PR on the latest master (which has the travis ci issue addressed)? Let me know if you need help on that.

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good but I've not tested it myself. The CI test is good.

@wing328 wing328 merged commit 7ad479e into OpenAPITools:master Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments