Implemented yaml parsing for config file.#2434
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Mar 18, 2019
Merged
Conversation
Member
|
@dragosnutu thanks for the enhancement, which looks good to me cc @OpenAPITools/generator-core-team |
wing328
approved these changes
Mar 18, 2019
wing328
approved these changes
Mar 18, 2019
Contributor
Author
|
@wing328 I'll try to add also the other idea to for the config-help to generate sample configurations with default value, maybe on another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.sh,./bin/security/{LANG}-petstore.shand./bin/openapi3/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
(details of the change, additional tests that have been done, reference to the issue for tracking, etc)
It implements #2425 support for yaml. It basically checks if the input file has
yamlorymlextension, if so it uses theYaml.mapper()for this. If any other extension, or empty (so no breaking change) it will use the oldJson.mapper().