Skip to content

Implemented yaml parsing for config file.#2434

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
dragosnutu:feature/yaml-config-file
Mar 18, 2019
Merged

Implemented yaml parsing for config file.#2434
wing328 merged 1 commit intoOpenAPITools:masterfrom
dragosnutu:feature/yaml-config-file

Conversation

@dragosnutu
Copy link
Contributor

@dragosnutu dragosnutu commented Mar 18, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

It implements #2425 support for yaml. It basically checks if the input file has yaml or yml extension, if so it uses the Yaml.mapper() for this. If any other extension, or empty (so no breaking change) it will use the old Json.mapper().

@wing328
Copy link
Member

wing328 commented Mar 18, 2019

@dragosnutu thanks for the enhancement, which looks good to me

cc @OpenAPITools/generator-core-team

@dragosnutu
Copy link
Contributor Author

@wing328 I'll try to add also the other idea to for the config-help to generate sample configurations with default value, maybe on another PR.

@wing328 wing328 merged commit 1f45ea7 into OpenAPITools:master Mar 18, 2019
@wing328 wing328 changed the title [#2425] - implemented yaml parsing for config file. Implemented yaml parsing for config file. Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments