[kotlin-spring] Enable reactor wrapper when serviceInterface is also …#2788
Closed
botcoder wants to merge 2 commits intoOpenAPITools:masterfrom
Closed
[kotlin-spring] Enable reactor wrapper when serviceInterface is also …#2788botcoder wants to merge 2 commits intoOpenAPITools:masterfrom
botcoder wants to merge 2 commits intoOpenAPITools:masterfrom
Conversation
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
Author
|
I guess besides the kotlin-springboot-petstore-server.sh, I was supposed to run "./bin/utils/export_docs_generators.sh" too... |
Contributor
yes, or |
Author
|
Unfortunately the solution proposed by #571 doesn't work, so I'm closing this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
Added "reactive=true" support to kotlin-spring generator, returning Flux/Mono wrappers, using serviceInterface
Limitations: reactive=true requires serviceInterface=true, or else it's just ignored as it currently is.
Fix #2765
@jimschubert , @dr4ke616 @karismann @Zomzog