[Golang][client] Make it possible to generate go.mod and go.sum files#2813
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom May 8, 2019
Merged
[Golang][client] Make it possible to generate go.mod and go.sum files#2813wing328 merged 1 commit intoOpenAPITools:masterfrom
wing328 merged 1 commit intoOpenAPITools:masterfrom
Conversation
Contributor
|
I think we need this also for go server. |
Contributor
Author
|
So after a Gitter discussion with @wing328 I made this use GIT_USER_ID and GIT_REPO_ID and generate go.mod and go.sum by default. |
Contributor
|
Hi @bkabrda, missed the thread on gitter, but this change makes the module definition very specific to GitHub repos. Might want to rethink the use of GIT_USER_ID and GIT_REPO_ID as the input to the generator. Perhaps specify the module path as a single path to the generator... |
bvwells
suggested changes
May 7, 2019
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.@antihax @bvwells @grokify @kemokemo
Description of the PR
Fixes #2796.
I didn't regenerate samples, since this is only triggered when moduleName is specified (either in config or on commandline). If you wish, I can definitely add this option to the scripts that generate samples and amend this PR.
I do have one question - it seems that the files under docs/generators are autogenerated, but I failed to find a script that generates them. Am I just looking wrong or are these handwritten? Thanks!