Skip to content

[Java][okhttp-gson] Making API response headers case insensitive#3029

Merged
wing328 merged 5 commits intoOpenAPITools:masterfrom
saigiridhar21:feat/java-okhttpgson/headers-insensitive
Jun 3, 2019
Merged

[Java][okhttp-gson] Making API response headers case insensitive#3029
wing328 merged 5 commits intoOpenAPITools:masterfrom
saigiridhar21:feat/java-okhttpgson/headers-insensitive

Conversation

@saigiridhar21
Copy link
Contributor

@saigiridhar21 saigiridhar21 commented May 29, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Closes:#3030

Making API response headers case insensitive.

Okhttp's Headers' class has only one method called "toMultiMap" which returns headers as Map. So, it is better handle it separately in APIResponse and ApiException classes separately.

I will be raising separate pull requests for other libraries of Java.

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04)

@saigiridhar21 saigiridhar21 changed the title Feat/java okhttpgson/headers insensitive feat(java-okhttpgson]: Making API response headers case insensitive May 29, 2019
@saigiridhar21 saigiridhar21 changed the title feat(java-okhttpgson]: Making API response headers case insensitive feat(java-okhttpgson): Making API response headers case insensitive May 30, 2019
@wing328 wing328 merged commit 6b7c5ed into OpenAPITools:master Jun 3, 2019
@wing328 wing328 added this to the 4.0.2 milestone Jun 3, 2019
@wing328 wing328 changed the title feat(java-okhttpgson): Making API response headers case insensitive [Java][okhttp-gson] Making API response headers case insensitive Jun 3, 2019
@saigiridhar21 saigiridhar21 deleted the feat/java-okhttpgson/headers-insensitive branch June 3, 2019 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[REQ] [Java-okhttpgson]: Make API response headers case insensitve

3 participants

Comments