Skip to content

[core] consider content in parameters and headers when computing unused schemas#3243

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
jmini:unused_schema_content
Jul 4, 2019
Merged

[core] consider content in parameters and headers when computing unused schemas#3243
wing328 merged 2 commits intoOpenAPITools:masterfrom
jmini:unused_schema_content

Conversation

@jmini
Copy link
Member

@jmini jmini commented Jun 28, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to [build the project]
    (https://github.com/OpenAPITools/openapi-generator#14---build-projects) first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language. @OpenAPITools/generator-core-team

Description of the PR

Introduced with #74 and updated with #1232 and #2138, the ModelUtils.getUnusedSchemas(OpenAPI) returns all schemas that are not used in an OpenAPI specification.

This PR fixes the case where a Schema is referenced in an Content of and Header or Parameter.

Original issue: #50

@auto-labeler
Copy link

auto-labeler bot commented Jun 28, 2019

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit 8d27857 into OpenAPITools:master Jul 4, 2019
@wing328 wing328 added this to the 4.0.3 milestone Jul 4, 2019
@jmini jmini deleted the unused_schema_content branch July 7, 2019 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants