Skip to content

Comments

[scala-play-server] Correct CLI option name#3340

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
todokr:scala-play-server__base-package
Jul 12, 2019
Merged

[scala-play-server] Correct CLI option name#3340
wing328 merged 1 commit intoOpenAPITools:masterfrom
todokr:scala-play-server__base-package

Conversation

@todokr
Copy link
Contributor

@todokr todokr commented Jul 11, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

The CLI option routesFileName is duplicated and the correct option name of later one ought to be basePackage.
Doc of scala-play-server

@auto-labeler
Copy link

auto-labeler bot commented Jul 11, 2019

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@wing328
Copy link
Member

wing328 commented Jul 12, 2019

--- a/docs/generators/scala-play-server.md
+++ b/docs/generators/scala-play-server.md
@@ -15,7 +15,7 @@ sidebar_label: scala-play-server
 |apiPackage|package for generated api classes| |null|
 |sourceFolder|source folder for generated code| |null|
 |routesFileName|Name of the routes file to generate.| |routes|
-|routesFileName|Base package in which supporting classes are generated.| |org.openapitools|
+|basePackage|Base package in which supporting classes are generated.| |org.openapitools|
 |skipStubs|If set, skips generation of stub classes.| |false|
 |supportAsync|If set, wraps API return types with Futures and generates async actions.| |false|
 |generateCustomExceptions|If set, generates custom exception types.| |true|

I'll update the doc later after merging it into master

@wing328 wing328 merged commit 09b4bbc into OpenAPITools:master Jul 12, 2019
@wing328
Copy link
Member

wing328 commented Jul 12, 2019

@todokr thanks for the PR, which has been merged into master.

@todokr todokr deleted the scala-play-server__base-package branch July 13, 2019 21:56
@wing328 wing328 added this to the 4.1.0 milestone Aug 9, 2019
@wing328
Copy link
Member

wing328 commented Aug 10, 2019

@todokr thanks for the PR, which has been included in the 4.1.0 release: https://twitter.com/oas_generator/status/1160000504455319553

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants