[typescript-angular] Add encoder configuration, fix default encoder#3389
[typescript-angular] Add encoder configuration, fix default encoder#3389macjohnny merged 7 commits intoOpenAPITools:masterfrom cubidobusinesssolutions:master
Conversation
#3372) * Add encoder to configuration * Fix import indention * Default encoder workaround for angular/angular#18261
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
|
cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10) @akehir (2019/07) |
macjohnny
left a comment
There was a problem hiding this comment.
Thanks for your PR! I think this is a very helpful configuration option.
I suggest to move the decision logic to the constructor.
modules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated
Show resolved
Hide resolved
* Extract encoder class variable initialized in constructor
|
@cubidobusinesssolutions can you please re-generate the samples?
|
|
Very nice, thanks ! |
I was hoping I would not have to install Java JRE, Java SDK, and Maven. See additional commits. |
* Fix typo * Add missing interface method implementation * Update samples
|
the remaining CI failure is unrelated |
|
@cubidobusinesssolutions thanks for the PR, which has been included in the 4.1.0 release: https://twitter.com/oas_generator/status/1160000504455319553 |
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master,4.1.x,5.0.x. Default:master.Description of the PR
(details of the change, additional tests that have been done, reference to the issue for tracking, etc)
fixes #3372