Various fix for Kotlin templates#3504
Conversation
Fix escaping of dataType field. Fix handling of arrays/lists of enums.
| typeMapping.put("binary", "kotlin.Array<kotlin.Byte>"); | ||
| typeMapping.put("Date", "java.time.LocalDate"); | ||
| typeMapping.put("DateTime", "java.time.LocalDateTime"); | ||
| typeMapping.put("ref", "kotlin.Any"); |
There was a problem hiding this comment.
Hi @wing328! Yes, there is no such type. But in spec I've got i see { "name": "request", "in": "formData", "description": "request", "required": false, "type": "ref" }
And that was generated by springfox swagger. I think that can be fixed some other way and will be happy to do it if you can recommend me how.
There was a problem hiding this comment.
I think it's bug in springfox based on the information you've provided as type: ref is not defined in the official openapi/swagger spec.
Given that it's a form parameter, what exactly is that? string? float?
What does the HTTP request payload look like?
There was a problem hiding this comment.
It looks like ref is default type https://github.com/swagger-api/swagger-core/blob/v1.5.21/modules/swagger-models/src/main/java/io/swagger/models/properties/RefProperty.java But it was changed in lates versions. Maybe that will help
There was a problem hiding this comment.
ref is not defined in the OpenAPI/Swagger spec. Please use a validator to validate the API spec/document first.
There was a problem hiding this comment.
I don't think we should include this in the generator, and rather require those who need it to pass this as a type mapping at generation time (see CLI options for example.
A ref in OpenAPI means something completely different than a top-level object type. Adding this means we need to support it through a deprecation cycle, and it may cause problems for others.
|
cc @jimschubert (2017/09), @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) |
|
Dear reviewers, can you give me please a hint what is wrong with Shippable ci job and how to fix it? |
|
I've restarted the shippable job. Let's see how it goes. |
|
@wing328 Thank you for rerunning shippable. Looks like all checks are ok now. Should I fix something else, or it would be fine to merge at some point? |
.../openapi-generator/src/main/java/org/openapitools/codegen/languages/KotlinClientCodegen.java
Show resolved
Hide resolved
|
@gimlet2 I noticed there's an additional Sorry for the delay, we had PR merges on hold for the 4.1.0 release. edit: After the explanation in your comment, I looked again and saw the usage in the templates. I just overlooked it previously. |
|
Thanks for the contribution! My previous question was a matter of my overlooking the value in the template. |
|
@jimschubert @wing328 Thank you for help with fixing it! 👍 |
|
@gimlet2 thanks for the PR, which has been included in the v4.1.1 release: https://twitter.com/oas_generator/status/1165944867391860737 |
|
I'm not sure if this is the right place or if I should open an issue, but in this PR, the OkHttp version was bumped from 3.14.2 to 4.0.1. This has a side effect that the Kotlin-client no longer supports Android 4.X version, it only supports Android 5.0 and upwards, because OkHttp 4.X only supports Android 5.0 and upwards. But the Android 4.X version still represents 10% of the global Android market share, and some companies still need to support those devices. I'm not sure if this change was an accident, but it would be great if Kotlin-client supports Android 4.X. So we have three possibilites:
What are your thoughts on this? Should I create an issue with this? EDIT: I created an issue #4007 |
5 participants
Fix escaping of dataType field.
Fix handling of arrays/lists of enums.
Update okhttp to 4.0.1
main issue was:
val `data`: ApiResponseListString.`Data`? = null, ... enum class `Data`(val value: kotlin.collection.List<kotlin.String>)instead of
val `data`: kotlin.collection.List<ApiResponseListString.`Data`>? = null,` `enum class `Data`(val value: kotlin.String)