Skip to content

[Ruby][Faraday] Various improvements#3520

Merged
wing328 merged 19 commits intomasterfrom
ruby_improve
Aug 1, 2019
Merged

[Ruby][Faraday] Various improvements#3520
wing328 merged 19 commits intomasterfrom
ruby_improve

Conversation

@wing328
Copy link
Member

@wing328 wing328 commented Aug 1, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

  • fix bug using url (including base path) instead of path
  • fix file upload
  • fix HTTP post (form parameters)

cc @cliffano (2017/07) @zlx (2017/09) @autopp (2019/02)

@autopp autopp self-requested a review August 1, 2019 12:04
@wing328
Copy link
Member Author

wing328 commented Aug 1, 2019

@autopp please take your time to review. I'll merge this for the time being to continue other works related to Ruby Faraday client generator.

@wing328 wing328 closed this Aug 1, 2019
@wing328 wing328 reopened this Aug 1, 2019
@wing328 wing328 merged commit ca85ecb into master Aug 1, 2019
@wing328 wing328 deleted the ruby_improve branch August 1, 2019 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant