[typescript] change accessToken name parameter to optional#3555
Merged
macjohnny merged 2 commits intoOpenAPITools:masterfrom Aug 5, 2019
Merged
[typescript] change accessToken name parameter to optional#3555macjohnny merged 2 commits intoOpenAPITools:masterfrom
macjohnny merged 2 commits intoOpenAPITools:masterfrom
Conversation
macjohnny
approved these changes
Aug 5, 2019
Member
macjohnny
left a comment
There was a problem hiding this comment.
LGTM.
I think this change is good, since the accessToken function is called with a name parameter in some cases, but not in all cases, see
Member
|
@blackdev1l thanks for the PR. Could you please re-generate and commit the samples? |
Contributor
Author
|
hey @macjohnny thanks for the review, |
Member
|
running |
Member
|
@blackdev1l thanks for the PR, which has been included in the 4.1.0 release: https://twitter.com/oas_generator/status/1160000504455319553 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master,4.1.x,5.0.x. Default:master.Description of the PR
fixes #2956
Iif you generate an axios API, you get a compilation error if tsconfig is set to 'strict'
because
configuration.accessToken()requires name as paramater (not optional) but here in the code generated it callsconfiguration.accessToken()without passing any parameters.I just made name an optional parameter.
I don't know if this is the right way to solve the issue, i would like to have some feedback about this.
@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10) @akehir (2019/07)