[aspnetcore] Add TypeConverter for enum string conversion#3557
[aspnetcore] Add TypeConverter for enum string conversion#3557jimschubert merged 2 commits intoOpenAPITools:masterfrom
Conversation
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
|
Thanks for the PR. I think we'll need to also consider using a TypeConverter to fix this issue, because this rename will:
|
|
@jimschubert changed to TypeConverter. Thanks! |
jimschubert
left a comment
There was a problem hiding this comment.
Regenerated samples appear to be changes pulled in from master.
|
Tested with the steps in the issue linked in the description and it appear to work as expected now. Valid enum returns a 200 (after modifying the generated controller to return 200 with empty body). Sending a request for an invalid enum value result in a 400 with body: Looks good! Thanks for fixing this issue! |
|
@frankyjuang Thanks again for the bug fix! Just wanted to let you know this is part of the recent 4.1.1 release. |
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master,4.1.x,5.0.x. Default:master.Description of the PR
If enum is used in query string, it can't be parsed with
EnumMember. AddTypeConverterto utilize json.net. #3513@wing328
@jimschubert
@mandrean