[Slim] Distinction between basicBasic and basicBearer authentication#3621
[Slim] Distinction between basicBasic and basicBearer authentication#3621wing328 merged 2 commits intoOpenAPITools:masterfrom chawax:master
Conversation
|
@chawax thanks for the PR. I'd a quick look and the PR looks good to me cc @jebentier (2017/07), @dkarlovi (2017/07), @mandrean (2017/08), @jfastnacht (2017/09), @ackintosh (2017/09), @ybelenko (2018/07), @renepardon (2018/12) |
|
Please run |
|
@chawax Thanks for the contributing! I'm working on new Slim4 generator which is based on current Slim3. I'll transfer this changes into new generator too. |
Mmh ... Do I have to install Maven to run this ? Is there another way to do this ? Don't want to "polluate" my Mac ... |
|
You can use maven wrapper, e.g. ./mvnw clean package |
OK, thanks ! I just updated the samples. |
|
@chawax thanks for the PR, which has been merged into master. For your upcoming PRs, I would recommend creating a separate branch for the change. |
|
@chawax thanks for the PR, which has been included in the v4.1.1 release: https://twitter.com/oas_generator/status/1165944867391860737 |
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master,4.1.x,5.0.x. Default:master.Description of the PR
I changed the
SlimRouter.mustachetemplate to distinguish between basic and bearer authentications. Then I change the regex depending on that.