Skip to content

[aspnetcore] Fix nullable enum and duplicate model#3622

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
milkjobs:fix-enum
Aug 13, 2019
Merged

[aspnetcore] Fix nullable enum and duplicate model#3622
wing328 merged 2 commits intoOpenAPITools:masterfrom
milkjobs:fix-enum

Conversation

@yilinjuang
Copy link
Contributor

@yilinjuang yilinjuang commented Aug 12, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Generate enum as nullable only if isNullable is true. Remove generation of sub-enum in class if enum is model which is already generated in another file.

@wing328
@jimschubert

@auto-labeler
Copy link

auto-labeler bot commented Aug 12, 2019

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@wing328 wing328 added this to the 4.1.1 milestone Aug 13, 2019
wing328
wing328 approved these changes Aug 13, 2019
View reviewed changes
Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit f5327b6 into OpenAPITools:master Aug 13, 2019
@yilinjuang yilinjuang deleted the fix-enum branch August 14, 2019 06:22
@wing328
Copy link
Member

wing328 commented Aug 26, 2019

@frankyjuang thanks for the PR, which has been included in the v4.1.1 release: https://twitter.com/oas_generator/status/1165944867391860737

@edag94
Copy link

edag94 commented Aug 26, 2019

Thanks for this PR! Will be closing the issue I raised and link it to this

This was referenced Aug 26, 2019
Closed
Open
@wing328
Copy link
Member

wing328 commented Sep 21, 2019

@frankyjuang when you've time next week, please kindly PM me via Slack

@yilinjuang yilinjuang mentioned this pull request Oct 7, 2019
Open
5 tasks
jeremy-audet added a commit to jeremy-audet/openapi-generator that referenced this pull request Dec 9, 2025
@jeremy-audet
Make python code compatible with urllib3 v2.6.0+
a1d4048 
openapi-generator still uses methods that have been removed from urllib3
v2.6.0. The solution is as described in urllib3's changelog:

> Removed the HTTPResponse.getheaders() method in favor of
> HTTPResponse.headers. Removed the HTTPResponse.getheader(name,
> default) method in favor of HTTPResponse.headers.get(name, default).
> (OpenAPITools#3622)

See https://urllib3.readthedocs.io/en/latest/changelog.html

Close OpenAPITools#22514
jeremy-audet added a commit to jeremy-audet/openapi-generator that referenced this pull request Dec 9, 2025
@jeremy-audet
Make python code compatible with urllib3 v2.6.0+
300de23 
openapi-generator still uses methods that have been removed from urllib3
v2.6.0. The solution is as described in urllib3's changelog:

> Removed the HTTPResponse.getheaders() method in favor of
> HTTPResponse.headers. Removed the HTTPResponse.getheader(name,
> default) method in favor of HTTPResponse.headers.get(name, default).
> (OpenAPITools#3622)

See https://urllib3.readthedocs.io/en/latest/changelog.html

Close OpenAPITools#22514
@jeremy-audet jeremy-audet mentioned this pull request Dec 9, 2025
Merged
jeremy-audet added a commit to jeremy-audet/openapi-generator that referenced this pull request Dec 9, 2025
@jeremy-audet
Make python code compatible with urllib3 v2.6.0+
924963a 
openapi-generator still uses methods that have been removed from urllib3
v2.6.0. The solution is as described in urllib3's changelog:

> Removed the HTTPResponse.getheaders() method in favor of
> HTTPResponse.headers. Removed the HTTPResponse.getheader(name,
> default) method in favor of HTTPResponse.headers.get(name, default).
> (OpenAPITools#3622)

See https://urllib3.readthedocs.io/en/latest/changelog.html

Close OpenAPITools#22514
jeremy-audet added a commit to jeremy-audet/openapi-generator that referenced this pull request Dec 9, 2025
@jeremy-audet
Make python code compatible with urllib3 v2.6.0+
4a52968 
openapi-generator still uses methods that have been removed from urllib3
v2.6.0. The solution is as described in urllib3's changelog:

> Removed the HTTPResponse.getheaders() method in favor of
> HTTPResponse.headers. Removed the HTTPResponse.getheader(name,
> default) method in favor of HTTPResponse.headers.get(name, default).
> (OpenAPITools#3622)

See https://urllib3.readthedocs.io/en/latest/changelog.html

Close OpenAPITools#22514
jeremy-audet added a commit to jeremy-audet/openapi-generator that referenced this pull request Dec 9, 2025
@jeremy-audet
Make python code compatible with urllib3 v2.6.0+
d95e70d 
openapi-generator still uses methods that have been removed from urllib3
v2.6.0. The solution is as described in urllib3's changelog:

> Removed the HTTPResponse.getheaders() method in favor of
> HTTPResponse.headers. Removed the HTTPResponse.getheader(name,
> default) method in favor of HTTPResponse.headers.get(name, default).
> (OpenAPITools#3622)

See https://urllib3.readthedocs.io/en/latest/changelog.html

Close OpenAPITools#22514
jeremy-audet added a commit to jeremy-audet/openapi-generator that referenced this pull request Dec 9, 2025
@jeremy-audet
Make python code compatible with urllib3 v2.6.0+
ea5b163 
openapi-generator still uses methods that have been removed from urllib3
v2.6.0. The solution is as described in urllib3's changelog:

> Removed the HTTPResponse.getheaders() method in favor of
> HTTPResponse.headers. Removed the HTTPResponse.getheader(name,
> default) method in favor of HTTPResponse.headers.get(name, default).
> (OpenAPITools#3622)

See https://urllib3.readthedocs.io/en/latest/changelog.html

Close OpenAPITools#22514
jeremy-audet added a commit to jeremy-audet/openapi-generator that referenced this pull request Dec 9, 2025
@jeremy-audet
Make python code compatible with urllib3 v2.6.0+
7f28841 
openapi-generator still uses methods that have been removed from urllib3
v2.6.0. The solution is as described in urllib3's changelog:

> Removed the HTTPResponse.getheaders() method in favor of
> HTTPResponse.headers. Removed the HTTPResponse.getheader(name,
> default) method in favor of HTTPResponse.headers.get(name, default).
> (OpenAPITools#3622)

See https://urllib3.readthedocs.io/en/latest/changelog.html

Close OpenAPITools#22514
jeremy-audet added a commit to jeremy-audet/openapi-generator that referenced this pull request Dec 9, 2025
@jeremy-audet
Make python code compatible with urllib3 v2.6.0+
b9ff5a0 
openapi-generator still uses methods that have been removed from urllib3
v2.6.0. The solution is as described in urllib3's changelog:

> Removed the HTTPResponse.getheaders() method in favor of
> HTTPResponse.headers. Removed the HTTPResponse.getheader(name,
> default) method in favor of HTTPResponse.headers.get(name, default).
> (OpenAPITools#3622)

See https://urllib3.readthedocs.io/en/latest/changelog.html

Close OpenAPITools#22514
jeremy-audet added a commit to jeremy-audet/openapi-generator that referenced this pull request Dec 9, 2025
@jeremy-audet
Make python code compatible with urllib3 v2.6.0+
1c882d1 
openapi-generator still uses methods that have been removed from urllib3
v2.6.0. The solution is as described in urllib3's changelog:

> Removed the HTTPResponse.getheaders() method in favor of
> HTTPResponse.headers. Removed the HTTPResponse.getheader(name,
> default) method in favor of HTTPResponse.headers.get(name, default).
> (OpenAPITools#3622)

See https://urllib3.readthedocs.io/en/latest/changelog.html

Close OpenAPITools#22514
wing328 pushed a commit that referenced this pull request Dec 9, 2025
@jeremy-audet
Make python code compatible with urllib3 v2.6.0+ (#22520)
cfcacf3 
openapi-generator still uses methods that have been removed from urllib3
v2.6.0. The solution is as described in urllib3's changelog:

> Removed the HTTPResponse.getheaders() method in favor of
> HTTPResponse.headers. Removed the HTTPResponse.getheader(name,
> default) method in favor of HTTPResponse.headers.get(name, default).
> (#3622)

See https://urllib3.readthedocs.io/en/latest/changelog.html

Close #22514
lucy66hw pushed a commit to lucy66hw/openapi-generator that referenced this pull request Dec 16, 2025
@jeremy-audet @luckyxilu66
Make python code compatible with urllib3 v2.6.0+ (OpenAPITools#22520)
56680ae 
openapi-generator still uses methods that have been removed from urllib3
v2.6.0. The solution is as described in urllib3's changelog:

> Removed the HTTPResponse.getheaders() method in favor of
> HTTPResponse.headers. Removed the HTTPResponse.getheader(name,
> default) method in favor of HTTPResponse.headers.get(name, default).
> (OpenAPITools#3622)

See https://urllib3.readthedocs.io/en/latest/changelog.html

Close OpenAPITools#22514
rajvesh pushed a commit to rajvesh/openapi-generator that referenced this pull request Dec 25, 2025
@jeremy-audet
Make python code compatible with urllib3 v2.6.0+ (OpenAPITools#22520)
ec682d1 
openapi-generator still uses methods that have been removed from urllib3
v2.6.0. The solution is as described in urllib3's changelog:

> Removed the HTTPResponse.getheaders() method in favor of
> HTTPResponse.headers. Removed the HTTPResponse.getheader(name,
> default) method in favor of HTTPResponse.headers.get(name, default).
> (OpenAPITools#3622)

See https://urllib3.readthedocs.io/en/latest/changelog.html

Close OpenAPITools#22514
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wing328 wing328 wing328 approved these changes

Assignees

No one assigned

Labels

Issue: Bug Server: C-Sharp

Projects

None yet

Milestone

4.1.1

Development

Successfully merging this pull request may close these issues.

3 participants

@yilinjuang @wing328 @edag94