Bugfix/3248#3857
Closed
peyerroger wants to merge 2 commits intoOpenAPITools:masterfrom
peyerroger:bugfix/3248
Closed
Bugfix/3248#3857peyerroger wants to merge 2 commits intoOpenAPITools:masterfrom peyerroger:bugfix/3248
peyerroger wants to merge 2 commits intoOpenAPITools:masterfrom
peyerroger:bugfix/3248
Conversation
6 tasks
4 tasks
jimschubert
reviewed
Sep 7, 2019
Member
jimschubert
left a comment
jimschubert
left a comment
There was a problem hiding this comment.
Thanks for the PR! I've left a few comments.
| * @param schema potentially containing a '$ref' | ||
| * @return true if it's a model with at least one properties | ||
| */ | ||
| public static boolean isModel(Schema schema) { |
Member
There was a problem hiding this comment.
Removing a public helper is a breaking change (these are used by programmatic consumers, and this would therefore need to be deprecated before removal).
| // property.baseType = getSimpleRef(p.get$ref()); | ||
| //} | ||
| // --END of revision | ||
| property.isModel = ModelUtils.isModel(p); |
Member
There was a problem hiding this comment.
If you're changing the template to not use isModel, we should keep this as the change affects all generators. See my resolution in #3855, which sets isModel as expected (after the naive attempt done in setNonArrayMapProperty.
| } | ||
|
|
||
| @Test | ||
| public void objectQueryParamIdentifyAsObject() { |
Member
There was a problem hiding this comment.
NOTE: Removing this test/functionality would be considered a breaking change and would need to be documented as a regression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master,4.1.x,5.0.x. Default:master.Description of the PR
(details of the change, additional tests that have been done, reference to the issue for tracking, etc)