Fix on PR: #888 RFC: [go] define "any-type" schema as an empty interface in generated go code.#3878
Fix on PR: #888 RFC: [go] define "any-type" schema as an empty interface in generated go code.#3878mattiabertorello wants to merge 6 commits intoOpenAPITools:masterfrom
Conversation
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
|
@mattiabertorello what about using if it works, we can add this mapping to the Abstract Go class. |
@wing328 Actually seems that with this parameter the generations works pretty good even without adding the mapping to the Abstract Go class. Can you confirm? |
|
If it works, we can hard code the mapping in the Abstract Go class rather than supplying this everytime via --type-mapping when running the generator. |
|
Looks very good to me, but we see that at this commit it was already changed in the past from |
on-behalf-of: @arduino <webmaster@arduino.cc>
217aa76 to
4dd3217
Compare
|
This is already done: https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractGoCodegen.java#L133 Please give the latest master a try. Closing this PR for the time being. |
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master,4.1.x,5.0.x. Default:master.Description of the PR
Fix issue point out here: #888 (comment)
@wing328 @ashanbrown @eclipse1985
@antihax (2017/11) @bvwells (2017/12) @grokify (2018/07)