Add Nim client code generator by hokamoto · Pull Request #3879 · OpenAPITools/openapi-generator

hokamoto · 2019-09-12T10:17:32Z

PR checklist

Read the contribution guidelines.
Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

I add the client code generator for Nim Programming Language.

* [Dart] Fix README template and update testing doco - deleted redundant shell script - fixed and updated README template - updated test package and moved to a dev_dependency - removed old unused dev_dependency packages - updated testing documentation in petstore sample * Remove references to dart-flutter-petstore.sh * Fix typos * Fix typo

* add gitHost param to GeneratorSettings and related * parameterize gitHost in READMEs * parameterize gitHost in go.mod * parameterize gitHost in git_push * update petstore samples * run ./bin/utils/export_docs_generators.sh * run meta-codehen.sh * Revert "run meta-codehen.sh" This reverts commit d6d579f. * Revert "run ./bin/utils/export_docs_generators.sh" This reverts commit 1b81538. * Revert "update petstore samples" This reverts commit f513add. * run ensure-up-to-date

* better varible naming * better comments * better code format for go experimental client * better comment, update samples

* add grpc protobuf generator * update doc * add new doc * add windows batch, comment out root proto

…efaultApi.java to match the default path /{pathParam} (OpenAPITools#3821)

…ols#3440)" This reverts commit 2a2eefe.

* issue OpenAPITools#2845: enable 'supportsMultipleInheritance' on typescript angular client codegen - note I reran ./bin/openapi3/typescript-angular-petstore-all.sh and no changes occurred. this suggests to me that the petstore.yaml sample should be improved to make use of the anyOf / allOf / oneOf keywords, in order to better show the effects of changes on generated code. * issue OpenAPITools#2845: run ./bin/openapi3/typescript-angular-petstore-all.sh * run `mvn clean package && ./bin/typescript-angular-petstore-all.sh` * revert extranous files

… hash calculation) (OpenAPITools#3826) * This patch fixes the bug that we cannot access to remote files when checking file updates. Following up OpenAPITools#3440, supporting auth. * 1792 fix remote spec handling and hash calculation (OpenAPITools#3440) (cherry picked from commit 2a2eefe) * fix detecting remote file / local file logic while finding the hash file, taking care of IllegalArgumentException for local files. * add testcase

…3846) * fixed bug where nullApi.java would be generated. Instead, generated DefaultApi.java to match the default path /{pathParam} * fix to bug OpenAPITools#3157 * update samples

…arameter (OpenAPITools#3860) Adds the format annotation so that Spring is able to serialize OpenApi date/date-time format into LocalDate/OffsetDateTime.

…to nim-client # Conflicts: # bin/windows/nim-client-petstore.bat

macjohnny

Thanks for the PR
Please also update the README.md to add the Nim language.
If you want, you could add yourself to the technical committee https://github.com/OpenAPITools/openapi-generator/blob/master/README.md#62---openapi-generator-technical-committee

modules/openapi-generator/src/test/java/org/openapitools/codegen/nim/NimClientCodegenTest.java

bin/nim-client-petstore.sh

hokamoto · 2019-09-12T13:13:41Z

Hi @macjohnny,
Tests by Travis CI failed due to a strange error. Could you advise me on how to solve it?

macjohnny · 2019-09-12T13:21:06Z

@hokamoto I think the error is unrelated, I restarted the build, let's see

macjohnny · 2019-09-12T13:55:09Z

the CI passes.
@wing328 can we merge this, as it is a new generator, or does anyone else have to review it?

wing328 · 2019-09-13T07:53:16Z

...les/openapi-generator/src/main/java/org/openapitools/codegen/languages/NimClientCodegen.java

@@ -0,0 +1,309 @@
+package org.openapitools.codegen.languages;


I'll add the copyright header in another PR.

wing328 · 2019-09-13T07:53:45Z

...les/openapi-generator/src/main/java/org/openapitools/codegen/languages/NimClientCodegen.java

+  }
+
+  public String getHelp() {
+    return "Generates a nim client.";


I'll add the word "beta" as follows:

Generates a nim client (beta).

wing328 · 2019-09-13T07:55:04Z

...les/openapi-generator/src/main/java/org/openapitools/codegen/languages/NimClientCodegen.java

+      return name;
+    }
+  }
+}


We're using 4 space indention so I'll reformat the code in a separate PR.

wing328 · 2019-09-13T07:56:48Z

@wing328 can we merge this, as it is a new generator, or does anyone else have to review it?

I left a couple of comments. Will work on those in a separate PR.

Let's launch this and see if nim developers have feedback on this new generator.

wing328 · 2019-09-13T10:43:18Z

@hokamoto thanks for the new generator. may I know if you've a Twitter account?

We'll tag you in the tweet to promote the new generator.

hokamoto · 2019-09-13T10:56:45Z

@wing328 Hi, my Twitter account is @tox2ro (https://twitter.com/tox2ro)

* master: (22 commits) various minor improvements to nim generator (#3883) Add Nim client code generator (#3879) updated google-api-client version from 1.23.0 to 1.30.2. Bugfix #3625 (#3882) typescript-fetch: fix missing comma in multiple imports (#3881) [scala][client] add Scala code generation test (#3859) typescript-node: Use HttpError class when rejecting promises (#3876) update stable release update doc, samples (#3875) BugFix #2053 Spring Boot fails to parse LocalDate query parameter (#3860) fix version in readme Prepare v4.1.2 release (#3873) Rename gRPC generator to "protobuf-schema" (#3864) typescript-axios: Fix baseoptions (#3866) Fix/r/serialization fix and minor 3xx resp fix (#3817) [typescript-angular] allow empty string basePath (#3489) typescript-inversify: improve check for required parameters, support multiple media types (#3849) [C++][Pistache] Add missing setter for arrays (#3837) Adds Http Info To Dart Api (#3851) [Java][okhttp-gson] fix failure to deserialize floats (#3846) maven-plugin-plugin 3.6.0 (#3854) ...

wing328 · 2019-09-13T12:55:06Z

Thanks. Here is the Tweet:

https://twitter.com/oas_generator/status/1172492657999794176

wing328 · 2019-10-04T14:20:48Z

@hokamoto thanks for the PR, which has been included in the v4.1.3 release: https://twitter.com/oas_generator/status/1180123829626003456

hokamoto and others added 30 commits September 2, 2019 08:26

First version of Nim Client

f266380

Add some codes

18d367a

Add some codes

9639569

Add some codes

a999b5e

Add some codes

5d73b11

Add some codes

3880039

First version of Nim Client

c48f0a0

Add some codes

c5e4713

Add some codes

feb96b1

Add some codes

5fdc0ab

Add some codes

ae33303

Add some codes

ba35508

Add links to article and video (OpenAPITools#3820)

2451702

Better Go code format (OpenAPITools#3819)

9ef73eb

* better varible naming * better comments * better code format for go experimental client * better comment, update samples

Add gRPC Protobuf schema generator (OpenAPITools#3818)

c90c6c8

* add grpc protobuf generator * update doc * add new doc * add windows batch, comment out root proto

1792 fix remote spec handling and hash calculation (OpenAPITools#3440)

bdfed92

fixed bug where nullApi.java would be generated. Instead, generated D…

7c5cfb7

…efaultApi.java to match the default path /{pathParam} (OpenAPITools#3821)

Revert "1792 fix remote spec handling and hash calculation (OpenAPITo…

99eb680

…ols#3440)" This reverts commit 2a2eefe.

Add nickmeinhold to Dart technical committee (OpenAPITools#3830)

ac1f19d

fix warnings in csharp-netcore client (OpenAPITools#3831)

9ba0dd0

Add missing files to the form request (OpenAPITools#3834)

5d21a8f

[client][go] avoid duplicated reflect imports (OpenAPITools#3847)

8c637fb

Add a link (OpenAPITools#3850)

4a1eb91

Add Element AI to the list (OpenAPITools#3856)

3228ca2

maven-plugin-plugin 3.6.0 (OpenAPITools#3854)

2fb08fb

[Java][okhttp-gson] fix failure to deserialize floats (OpenAPITools#…

221443a

…3846) * fixed bug where nullApi.java would be generated. Instead, generated DefaultApi.java to match the default path /{pathParam} * fix to bug OpenAPITools#3157 * update samples

peyerroger and others added 6 commits September 12, 2019 18:55

BugFix OpenAPITools#2053 Spring Boot fails to parse LocalDate query p…

580ca11

…arameter (OpenAPITools#3860) Adds the format annotation so that Spring is able to serialize OpenApi date/date-time format into LocalDate/OffsetDateTime.

update doc, samples (OpenAPITools#3875)

fbb3b27

update stable release

549fc8f

Update the batch for Windows

bface47

Merge branch 'nim-client' of github.com:hokamoto/openapi-generator in…

5a28be0

…to nim-client # Conflicts: # bin/windows/nim-client-petstore.bat

Merge remote-tracking branch 'upstream/master' into nim-client

19cc13b

macjohnny approved these changes Sep 12, 2019

View reviewed changes

modules/openapi-generator/src/test/java/org/openapitools/codegen/nim/NimClientCodegenTest.java Outdated Show resolved Hide resolved

bin/nim-client-petstore.sh Show resolved Hide resolved

hokamoto added 4 commits September 12, 2019 20:23

Add a test snippet

2db44c7

Update ensure-up-to-date

bcec49b

Add Nim to README.md

7276034

Ran ensure-up-to-date to pass CircleCI tests

090875b

macjohnny added this to the 4.1.3 milestone Sep 12, 2019

macjohnny added Feature: Generator Enhancement: New generator labels Sep 12, 2019

wing328 reviewed Sep 13, 2019

View reviewed changes

wing328 approved these changes Sep 13, 2019

View reviewed changes

wing328 merged commit f15f814 into OpenAPITools:master Sep 13, 2019

wing328 added the Client: Nim label Sep 13, 2019

hokamoto deleted the nim-client branch September 13, 2019 08:46

		@@ -0,0 +1,309 @@
		package org.openapitools.codegen.languages;

Uh oh!

Conversation

hokamoto commented Sep 12, 2019

PR checklist

Description of the PR

Uh oh!

macjohnny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

hokamoto commented Sep 12, 2019

Uh oh!

macjohnny commented Sep 12, 2019

Uh oh!

macjohnny commented Sep 12, 2019

Uh oh!

wing328 Sep 13, 2019

Choose a reason for hiding this comment

Uh oh!

wing328 Sep 13, 2019

Choose a reason for hiding this comment

Uh oh!

wing328 Sep 13, 2019

Choose a reason for hiding this comment

Uh oh!

wing328 commented Sep 13, 2019

Uh oh!

wing328 commented Sep 13, 2019

Uh oh!

hokamoto commented Sep 13, 2019

Uh oh!

wing328 commented Sep 13, 2019

Uh oh!

wing328 commented Oct 4, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants