[java] Don't import oltu when not necessary#3950
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Oct 1, 2019
mwalser:java-conditionally-import-oltu
Merged
[java] Don't import oltu when not necessary#3950wing328 merged 1 commit intoOpenAPITools:masterfrom mwalser:java-conditionally-import-oltu
wing328 merged 1 commit intoOpenAPITools:masterfrom
mwalser:java-conditionally-import-oltu
Conversation
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
Member
|
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
Contributor
Author
|
Hi, thanks for the notice. I've now linked the email associated with the PR to my account, so this commit shows up as mine. |
Jesse0Michael
pushed a commit
to Jesse0Michael/openapi-generator
that referenced
this pull request
Oct 3, 2019
Member
|
@mwalser thanks for the PR, which has been included in v4.2.0 release: https://twitter.com/oas_generator/status/1189824932345069569 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master,4.1.x,5.0.x. Default:master.CC: @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04)
Description of the PR
The Apache Oltu library is only needed when OAuth is used.
Currently a user is forced to add an Oltu dependency even though it is not used. This PR changes the template to only import Oltu when needed.