Restore unit test that consider minLength, maxLength and pattern in referenced schema#401
Merged
jmini merged 1 commit intoOpenAPITools:3.1.xfrom Jun 26, 2018
Merged
Conversation
When they are defined in a in referenced schema Originally introduced with OpenAPITools#45, reverted with OpenAPITools#82
This was referenced Jun 26, 2018
Merged
Member
Author
|
Unit tests are green, this PR is just about new assertions in one unit test, no changes to the implementation. => Self approving. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR restores the unit test that consider
minLength,maxLengthandpatternwhen they are defined in a in referenced schema.OAS2 example:
This was filed as originally as swagger-api/swagger-codegen#8001
I have tried to implement a solution for this with #45, but my solution had too many side effects and was reverted with #82.
This PR brings back the tests without changing anything to the implementation. I think the changes made with #360 by @wing328 solves also issue swagger-api/swagger-codegen#8001.