[CSharp] add optional flag "optionalEmitDefaultValues" and update template#4010
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Oct 9, 2019
sdoeringNew:master
Merged
[CSharp] add optional flag "optionalEmitDefaultValues" and update template#4010wing328 merged 1 commit intoOpenAPITools:masterfrom sdoeringNew:master
wing328 merged 1 commit intoOpenAPITools:masterfrom
sdoeringNew:master
Conversation
…plate This commit addresses issue #3274 and adds the proposed optionalEmitDefaultValues flag.
Member
|
@sdoeringNew thanks for the PR. We can go with this approach to see if users have feedback on this. |
Member
|
I would recommend creating a new branch as per git best practic for your upcoming PRs. |
Member
|
@sdoeringNew thanks for the PR, which has been included in v4.2.0 release: https://twitter.com/oas_generator/status/1189824932345069569 |
1 task
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample for CSharp... But I haven't committed them because there were many other changes from previous template changes - so nobody seem to commit them. At least I saw that the flag worked as expected.masterDescription of the PR
This commit addresses issue #3274 and adds the proposed
optionalEmitDefaultValuesflag.Invite cool reviewers
@mandrean (2017/08), @jimschubert (2017/09)