[Java] Additional annotations for model type (class level annotations)#4026
Merged
jimschubert merged 4 commits intoOpenAPITools:masterfrom Dec 3, 2019
Merged
Conversation
borsch
force-pushed
the
issue-4025-custom-java-annotations
branch
from
4dfca44 to
2dd5cfd
Compare
borsch
force-pushed
the
issue-4025-custom-java-annotations
branch
from
2dd5cfd to
d4a6479
Compare
Member
Author
|
@wing328 @jimschubert could you please look at this? |
jimschubert
reviewed
Dec 2, 2019
Member
jimschubert
left a comment
jimschubert
left a comment
There was a problem hiding this comment.
Thanks for the contribution. Just a few minor comments.
modules/openapi-generator/src/main/resources/Java/additionalModelTypeAnnotations.mustache
Outdated
Show resolved
Hide resolved
modules/openapi-generator/src/main/resources/JavaVertXWebServer/pojo.mustache
Outdated
Show resolved
Hide resolved
borsch
force-pushed
the
issue-4025-custom-java-annotations
branch
from
c358b65 to
c3150e5
Compare
jimschubert
approved these changes
Dec 3, 2019
Member
wing328
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master,4.1.x,5.0.x. Default:master.Description of the PR
#4025
I want to have an ability to specify my custom annotations for model type. This will allow to add annotations from tools like
lombokor in case if you have you customAnnotationProcessorwith own annotation