[Kotlin] Add kotlin.collections.Set support for unique item arrays#4247
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Oct 28, 2019
mtraynham:kotlin_set_support
Merged
[Kotlin] Add kotlin.collections.Set support for unique item arrays#4247wing328 merged 1 commit intoOpenAPITools:masterfrom mtraynham:kotlin_set_support
wing328 merged 1 commit intoOpenAPITools:masterfrom
mtraynham:kotlin_set_support
Conversation
Member
|
@mtraynham thanks for the PR, which looks good to me. |
Contributor
Author
|
Thanks @wing328 ! |
jimschubert
reviewed
Oct 28, 2019
Member
jimschubert
left a comment
There was a problem hiding this comment.
Doesn't this cause compilation error because instantiation currently only knows of maps and lists?
Member
|
Oh. I see that the change affects the generic type construction, and we're not changing actual type mapping for the array type (which would need a |
Member
|
@mtraynham thanks for the PR, which has been included in v4.2.0 release: https://twitter.com/oas_generator/status/1189824932345069569 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for
kotlin.collections.Setarray types, when interpretingArraySchema.getUniqueItems()PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.1.x,5.0.x. Default:master.@jimschubert @dr4ke616 @karismann @Zomzog