Skip to content

Minor improvement to the Java vertx web server generator#4294

Merged
wing328 merged 2 commits intomasterfrom
vertx_improve
Oct 28, 2019
Merged

Minor improvement to the Java vertx web server generator#4294
wing328 merged 2 commits intomasterfrom
vertx_improve

Conversation

@wing328
Copy link
Member

@wing328 wing328 commented Oct 28, 2019

Minor improvement to the Java vertx web server generator

  • mark as beta
  • minor change to default output directory
  • update template creator

cc @lwlee2608

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04)

* Java Undertow: @stevehu
* Java Play Framework: @JFCote
* Java PKMST: @anshu2185 @sanshuman @rkumar-pk @ninodpillai
* Java Vert.x: @lwlee2608
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

@wing328 wing328 merged commit e37d8bc into master Oct 28, 2019
@wing328 wing328 deleted the vertx_improve branch October 30, 2019 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants