[go-experimental] Remove duplicated line#4410
Merged
jimschubert merged 4 commits intoOpenAPITools:masterfrom Dec 17, 2019
Merged
[go-experimental] Remove duplicated line#4410jimschubert merged 4 commits intoOpenAPITools:masterfrom
jimschubert merged 4 commits intoOpenAPITools:masterfrom
Conversation
zippolyte
changed the title
Contributor
Author
|
|
bkabrda
suggested changes
Nov 8, 2019
Contributor
bkabrda
left a comment
bkabrda
left a comment
There was a problem hiding this comment.
Please try to make sure that you're running this with the latest checkout of openapi-generator and that you're using the jar built from this latest checkout. I think you might be using an older version locally which causes the double-import issue.
Contributor
There was a problem hiding this comment.
This change doesn't look right. Did you properly rebase your local copy to latest master?
zippolyte
force-pushed
the
hippo/rm_dup
branch
from
e093b03 to
a7a1496
Compare
zippolyte
force-pushed
the
hippo/rm_dup
branch
from
a7a1496 to
12b8eb1
Compare
Contributor
Author
|
Hey @wing328, I would love to get this merged in. Could you take a look ? |
zippolyte
force-pushed
the
hippo/rm_dup
branch
from
12b8eb1 to
e6486a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3322 Introduces a duplication of the return statement in https://github.com/OpenAPITools/openapi-generator/pull/3322/files#diff-5c6a68868625dbd29066148ecab2c4b8R334
This PR removes that duplication
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.cc @bkabrda