[Java][Go] Unalias schema in getTypeDeclaration when not generating model for alias#4527
Conversation
|
@zippolyte thanks for the PR. I think it's better to fix it in the DefaultCodegen. I'll try to fix it later this week. |
| ArraySchema ap = (ArraySchema) p; | ||
| Schema inner = ap.getItems(); | ||
| return "[]" + getTypeDeclaration(inner); | ||
| if (ModelUtils.isGenerateAliasAsModel()) |
There was a problem hiding this comment.
@zippolyte I don't think you need ModelUtils.isGenerateAliasAsModel() as unaliasSchema has already taken that into account:
|
UPDATE: I've reviewed your fix again and I think it's the right approach. I've left a comment suggesting a minor change. Please review when you've time. Thanks again for the PR. |
|
Indeed it seems I don't need that after all. Thanks for your review, updating. |
bkabrda
left a comment
bkabrda
left a comment
There was a problem hiding this comment.
This looks perfect, 👍 from me.
|
@zippolyte thanks for the PR, which has been merged into master. I've filed #4563 to track the fixes for other generators. |
|
@zippolyte thanks for the PR, which has been included in the v4.2.2 release: https://twitter.com/oas_generator/status/1201432648544972800 |
3 participants
This is my attempt to fix #4362 for the two languages that I'm having this issue with.
What do you think ?
@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608
@antihax @bvwells @grokify @kemokemo @bkabrda
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.