[Python] Removes mutable default argument#4665
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Dec 17, 2019
Merged
Conversation
jirikuncar
force-pushed
the
python-mutable-default-argument-no-docstrings
branch
from
3ce66f1 to
0e4189a
Compare
spacether
approved these changes
Dec 3, 2019
Contributor
spacether
left a comment
spacether
left a comment
There was a problem hiding this comment.
This looks good, thanks for the PR!
5 tasks
Contributor
Author
|
@taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11) @tomplus (2018/10) @Jyhess (2019/01) @slash-arun (2019/11) @spacether (2019/11) is there anything else I should address in this PR? |
Contributor
|
@jirikuncar not that I know of. On the language committee we are able to approve but not merge PRs. I just pinged the core team in our public Slack asking for a merge or further review of this PR. |
Member
|
@jirikuncar thanks for the PR @spacether thanks for reviewing the change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minimal change from #4613 to avoid useless discussion about property docstrings.
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.cc @taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11) @tomplus (2018/10) @Jyhess (2019/01) @slash-arun (2019/11) ... @spacether (2019/11)