[dart-dio] Fixes enum by setting the wireName to the correct value#4708
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Dec 12, 2019
Merged
[dart-dio] Fixes enum by setting the wireName to the correct value#4708wing328 merged 1 commit intoOpenAPITools:masterfrom
wing328 merged 1 commit intoOpenAPITools:masterfrom
Conversation
Contributor
|
I haven't worked on this stuff for a while, when I made a generator that used built_value I vaguely remember having to mess around with using value vs name for the wirename and digging into the java to understand the difference but I've forgotten it all now so I'm not much use here sorry. I'm sure you know what you're doing. I can't finish without saying something about tests. There, said it. |
Contributor
Author
|
I'm pretty sure In my case the values are returned from the api like |
Contributor
|
Ah right, that’s sounding familiar now, thanks for the explanation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.CC @ircecho @swipesight @jaumard @nickmeinhold