[C-libcurl] Change baseName to name to escape the field name of struct#4735
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Dec 10, 2019
ityuhui:yhworking
Merged
[C-libcurl] Change baseName to name to escape the field name of struct#4735wing328 merged 1 commit intoOpenAPITools:masterfrom ityuhui:yhworking
wing328 merged 1 commit intoOpenAPITools:masterfrom
ityuhui:yhworking
Conversation
…cludes C programming language keyword
6 tasks
Member
|
Right, let's go with |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change "baseName" to "name" to escape the field name of struct when it includes C programming language keyword
As described in Issue 4700
I found "baseName" cannot be escaped for the keyword, only "name" can.
I checked this part in cpp-rest-sdk-client and cpp-qt5-client, they do not use "baseName", but use "name". So I have made these code change.
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.@wing328 @PowerOfCreation @zhemant