[C-libcurl] fix building error when complexType is empty.#4768
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Dec 12, 2019
ityuhui:yhworking
Merged
[C-libcurl] fix building error when complexType is empty.#4768wing328 merged 1 commit intoOpenAPITools:masterfrom ityuhui:yhworking
wing328 merged 1 commit intoOpenAPITools:masterfrom
ityuhui:yhworking
Conversation
… building error when complexType is empty.
Contributor
Author
|
Hi @wing328 The check of Shippable always failed because "build_ci" cannot succeed. I think it's an envionment issue. |
Member
|
Right I tried to restart it a couple of times but still no luck. Let me give it a try this evening to see if we've any luck. |
Member
|
Shippable CI fixed in the master |
Member
|
The shippable error has been fixed in the master. |
wing328
approved these changes
Dec 12, 2019
Member
wing328
left a comment
There was a problem hiding this comment.
Thanks for the fix, which looks ok to me. (haven't tested it locally)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[C-libcurl] Change "complexType" to "name" inner "isMapContainer" to fix building error when complexType is empty.
When generating k8s C-libcurl client, there is a build error due to the duplicated List
They are generated by the below template code:
But for my case, complexType is empty, so there are some duplicated List
They will cause building error.
I checked other parts inner the {{#isMapContainer}} and {{/isMapContainer}} in the same file, and found "complexType" should be changed to "name"
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.@wing328 @PowerOfCreation @zhemant