Skip to content

[C-libcurl] fix building error when complexType is empty.#4768

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
ityuhui:yhworking
Dec 12, 2019
Merged

[C-libcurl] fix building error when complexType is empty.#4768
wing328 merged 1 commit intoOpenAPITools:masterfrom
ityuhui:yhworking

Conversation

@ityuhui
Copy link
Contributor

@ityuhui ityuhui commented Dec 11, 2019

[C-libcurl] Change "complexType" to "name" inner "isMapContainer" to fix building error when complexType is empty.

When generating k8s C-libcurl client, there is a build error due to the duplicated List

They are generated by the below template code:

{{#isMapContainer}}
    list_t *{{{complexType}}}List;
...
{{/isMapContainer}} 

But for my case, complexType is empty, so there are some duplicated List

list_t *List;
...
list_t *List;
...
list_t *List;

They will cause building error.

I checked other parts inner the {{#isMapContainer}} and {{/isMapContainer}} in the same file, and found "complexType" should be changed to "name"

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the master: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328 @PowerOfCreation @zhemant

@ityuhui ityuhui marked this pull request as ready for review December 11, 2019 05:26
@wing328 wing328 added this to the 4.2.3 milestone Dec 11, 2019
@ityuhui
Copy link
Contributor Author

ityuhui commented Dec 11, 2019

Hi @wing328

The check of Shippable always failed because "build_ci" cannot succeed. I think it's an envionment issue.

@wing328
Copy link
Member

wing328 commented Dec 11, 2019

Right I tried to restart it a couple of times but still no luck. Let me give it a try this evening to see if we've any luck.

@wing328
Copy link
Member

wing328 commented Dec 12, 2019

Shippable CI fixed in the master

@wing328
Copy link
Member

wing328 commented Dec 12, 2019

The shippable error has been fixed in the master.

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, which looks ok to me. (haven't tested it locally)

@wing328 wing328 merged commit 1e995ca into OpenAPITools:master Dec 12, 2019
@ityuhui ityuhui deleted the yhworking branch December 13, 2019 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants