[typescript-angular] Control Accept header via param#4774
Merged
macjohnny merged 4 commits intoOpenAPITools:masterfrom Dec 13, 2019
oaklandcorp:fix_issue686
Merged
[typescript-angular] Control Accept header via param#4774macjohnny merged 4 commits intoOpenAPITools:masterfrom oaklandcorp:fix_issue686
macjohnny merged 4 commits intoOpenAPITools:masterfrom
oaklandcorp:fix_issue686
Conversation
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
macjohnny
reviewed
Dec 12, 2019
modules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated
Show resolved
Hide resolved
modules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated
Show resolved
Hide resolved
Member
|
@djnalluri thanks for your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the typescript-angular part of #686.
A new parameter is added to the typescript definition for the operations. This parameter is typed to only accept strings matching possible producer mime types or undefined. If undefined, it executes default behaviour prior to this PR.
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.Technical Committee:
@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11)