Skip to content

[Swift 4] add nullable support#4825

Closed
4brunu wants to merge 3 commits intoOpenAPITools:4.3.xfrom
4brunu:feature/swift_support_for_nullable
Closed

[Swift 4] add nullable support#4825
4brunu wants to merge 3 commits intoOpenAPITools:4.3.xfrom
4brunu:feature/swift_support_for_nullable

Conversation

@4brunu
Copy link
Contributor

@4brunu 4brunu commented Dec 18, 2019

This PR is a continuation of #3783

Add nullable (or x-nullable in OAS2) support to swift4

This will replace the unwrapRequired option.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @4brunu (2019/11)

@4brunu 4brunu mentioned this pull request Dec 18, 2019
5 tasks
@4brunu
Copy link
Contributor Author

4brunu commented Dec 18, 2019

@wing328 has talked in #4754, I think this now is ready to merge 🙂

@wing328 wing328 mentioned this pull request Dec 22, 2019
4 tasks
@4brunu
Copy link
Contributor Author

4brunu commented Jan 2, 2020

Close in favor of #4086

@4brunu 4brunu closed this Jan 2, 2020
@4brunu 4brunu deleted the feature/swift_support_for_nullable branch May 18, 2020 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants