[typescript-axios] Fixed call of toISOString on a string type when using string type-mapping#5057
Merged
macjohnny merged 1 commit intoOpenAPITools:masterfrom Jan 20, 2020
LiamMartens:typescript-axios-datetime-toisostring
Merged
[typescript-axios] Fixed call of toISOString on a string type when using string type-mapping#5057macjohnny merged 1 commit intoOpenAPITools:masterfrom LiamMartens:typescript-axios-datetime-toisostring
macjohnny merged 1 commit intoOpenAPITools:masterfrom
LiamMartens:typescript-axios-datetime-toisostring
Conversation
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
macjohnny
approved these changes
Jan 20, 2020
maccuaa
added a commit
to maccuaa/intellitrust-js-sdk
that referenced
this pull request
Feb 3, 2020
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @nicokoenig @topce @akehir @petejohansonxo
Created a detailed repro repository here
Basic gist of it is the following, let's assume you have following swagger definition
When type mapping
datetostringthis results in the following generated codeThis same fix was applied to the
isDatetemplate.PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.