[csharp-netcore] Improved Multimap and ClientUtils implementation#5122
Merged
wing328 merged 9 commits intoOpenAPITools:masterfrom Feb 2, 2020
shibayan:multimap-netcore
Merged
[csharp-netcore] Improved Multimap and ClientUtils implementation#5122wing328 merged 9 commits intoOpenAPITools:masterfrom shibayan:multimap-netcore
Multimap and ClientUtils implementation#5122wing328 merged 9 commits intoOpenAPITools:masterfrom
shibayan:multimap-netcore
Conversation
Member
|
LGTM. If no further feedback, I'll merge the PR tomorrow. |
Contributor
Author
|
The conflict has been resolved. |
Member
|
@shibayan do you mind resolving the merge conflicts again? I may have merged other PRs first resulting in the merge conflicts. |
jimschubert
added a commit
to jimschubert/openapi-generator
that referenced
this pull request
Feb 3, 2020
* master: [cli] Optional colorized outputs (OpenAPITools#5193) [bug] fix null pointer exception while evaluating recommend… (OpenAPITools#5191) [csharp-netcore] Improved `Multimap` and `ClientUtils` implementation (OpenAPITools#5122)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR detail
Multimap<K,V>ConcurrentDictionary<K,V>because it is not operated from multiple threadsAdd(Multimap<K,V>)PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.@mandrean @jimschubert @frankyjuang