Skip to content

[csharp-netcore] Improved Multimap and ClientUtils implementation#5122

Merged
wing328 merged 9 commits intoOpenAPITools:masterfrom
shibayan:multimap-netcore
Feb 2, 2020
Merged

[csharp-netcore] Improved Multimap and ClientUtils implementation#5122
wing328 merged 9 commits intoOpenAPITools:masterfrom
shibayan:multimap-netcore

Conversation

@shibayan
Copy link
Contributor

@shibayan shibayan commented Jan 27, 2020

PR detail

  • Improvement Multimap<K,V>
    • Do not use ConcurrentDictionary<K,V> because it is not operated from multiple threads
    • Adding overload methods Add(Multimap<K,V>)
    • Improved API implementation complexity
  • Improved runtime type checking
    • Use pattern matching
  • Changed to an implementation that considers memory usage efficiency
    • Improved stream handling

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@mandrean @jimschubert @frankyjuang

@wing328
Copy link
Member

wing328 commented Jan 29, 2020

LGTM. If no further feedback, I'll merge the PR tomorrow.

@shibayan
Copy link
Contributor Author

The conflict has been resolved.

@wing328 wing328 modified the milestones: 4.2.3, 5.0.0, 4.3.0 Jan 31, 2020
@wing328
Copy link
Member

wing328 commented Feb 1, 2020

@shibayan do you mind resolving the merge conflicts again? I may have merged other PRs first resulting in the merge conflicts.

@wing328 wing328 merged commit f356de6 into OpenAPITools:master Feb 2, 2020
@shibayan shibayan deleted the multimap-netcore branch February 2, 2020 16:20
jimschubert added a commit to jimschubert/openapi-generator that referenced this pull request Feb 3, 2020
* master:
  [cli] Optional colorized outputs (OpenAPITools#5193)
  [bug] fix null pointer exception while evaluating recommend… (OpenAPITools#5191)
  [csharp-netcore] Improved `Multimap` and `ClientUtils` implementation (OpenAPITools#5122)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants