Skip to content

Use EXISTING_PROPERTY for JavaSpring as well#5243

Merged
jimschubert merged 1 commit intoOpenAPITools:masterfrom
keenanpepper:existing-property-javaspring
Feb 8, 2020
Merged

Use EXISTING_PROPERTY for JavaSpring as well#5243
jimschubert merged 1 commit intoOpenAPITools:masterfrom
keenanpepper:existing-property-javaspring

Conversation

@keenanpepper
Copy link
Contributor

@keenanpepper keenanpepper commented Feb 8, 2020

This fixes issue #3796 for JavaSpring. It's a very straightfoward extension
of #5120 for the JavaSpring generator (that PR was just for the Java generator).

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

This fixes issue OpenAPITools#3796 for JavaSpring. It's a very straightfoward extension
of OpenAPITools#5120 for the JavaSpring generator (that PR was just for the Java generator).
@keenanpepper
Copy link
Contributor Author

@bkabrda @jimschubert

@jimschubert jimschubert added this to the 4.3.0 milestone Feb 8, 2020
@jimschubert
Copy link
Member

Thanks for adding this consistency across the Java generators supporting discriminators.

@jimschubert jimschubert merged commit 9126a56 into OpenAPITools:master Feb 8, 2020
MikailBag pushed a commit to MikailBag/openapi-generator that referenced this pull request Mar 23, 2020
This fixes issue OpenAPITools#3796 for JavaSpring. It's a very straightfoward extension
of OpenAPITools#5120 for the JavaSpring generator (that PR was just for the Java generator).
@wing328
Copy link
Member

wing328 commented Mar 27, 2020

@keenanpepper thanks for the PR, which has been included in the 4.3.0 release: https://twitter.com/oas_generator/status/1243455743937789952

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments