[Java] springmvc lombok models#5430
Closed
com2ghz wants to merge 21 commits intoOpenAPITools:masterfrom
Closed
Conversation
|
Imports are still not generated for me. I just hot fixed it with diff --git a/modules/openapi-generator/src/main/resources/JavaSpring/model.mustache b/modules/openapi-generator/src/main/resources/JavaSpring/model.mustache
index fbe3a9f1..8054318b 100644
--- a/modules/openapi-generator/src/main/resources/JavaSpring/model.mustache
+++ b/modules/openapi-generator/src/main/resources/JavaSpring/model.mustache
@@ -28,6 +28,9 @@ import javax.xml.bind.annotation.*;
import org.springframework.hateoas.RepresentationModel;
{{/hateoas}}
{{/parent}}
+{{#isLombokModel}}
+import lombok.*;
+{{/isLombokModel}}
{{#models}}
{{#model}} |
twrzos
approved these changes
Oct 20, 2020
|
Is this PR still relevant? I realized it was approved on 2020... Despite not using myself OpenAPI generator right now, it would be very, very, nice to have Lombok in Java models =) |
Author
No, I will close this PR. You can do lombok using the annotations and creating the templates. I might make a PR for that in the future |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For spring-mvc you can enable lombok for your models. This encourages the use of immutable objects that comes with a builder.
When lombok is enabled, there are no setters anymore.
Using a builder is very convenient for unit testing.
So the following annotations are added to your model:
Currently only available for language: spring and library spring-mvc with additional-properties isLombokModel
Example:
generate -i swagger.yaml -g spring --library spring-mvc --additional-properties isLombokModel -o src/1111
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.