typescript-angular: spaceDelimited fix for parameters (#5630)#5631
Closed
LPCmedia wants to merge 2 commits intoOpenAPITools:masterfrom
LPCmedia:master
Closed
typescript-angular: spaceDelimited fix for parameters (#5630)#5631LPCmedia wants to merge 2 commits intoOpenAPITools:masterfrom LPCmedia:master
LPCmedia wants to merge 2 commits intoOpenAPITools:masterfrom
LPCmedia:master
Conversation
Author
|
@amakhrov let me know. |
Member
|
this is in conflict with #5000 by @DavidBiesack @jimschubert we should stick to #5000, right? |
macjohnny
reviewed
Mar 19, 2020
Author
|
all good for me. Let me know if I can do something to help as #5000 is not building at the moment. |
Member
|
Yeah, we should stick to what's defined in the spec. Collection format is ssv in 2.0 and replaced with a style parameter in 3.x (see https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.2.md#style-values). The change in this PR would mix the two concepts. |
Author
|
@jimschubert should I work off #5000 to ensure the build passes or it that something imminent ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.