Skip to content

typescript-angular: spaceDelimited fix for parameters (#5630)#5631

Closed
LPCmedia wants to merge 2 commits intoOpenAPITools:masterfrom
LPCmedia:master
Closed

typescript-angular: spaceDelimited fix for parameters (#5630)#5631
LPCmedia wants to merge 2 commits intoOpenAPITools:masterfrom
LPCmedia:master

Conversation

@LPCmedia
Copy link

@LPCmedia LPCmedia commented Mar 19, 2020

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@LPCmedia
Copy link
Author

@amakhrov let me know.

@macjohnny
Copy link
Member

this is in conflict with #5000 by @DavidBiesack

@jimschubert we should stick to #5000, right?

Copy link
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conflicts with #5000

@LPCmedia
Copy link
Author

all good for me. Let me know if I can do something to help as #5000 is not building at the moment.

@jimschubert
Copy link
Member

Yeah, we should stick to what's defined in the spec. Collection format is ssv in 2.0 and replaced with a style parameter in 3.x (see https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.2.md#style-values). The change in this PR would mix the two concepts.

@LPCmedia
Copy link
Author

@jimschubert should I work off #5000 to ensure the build passes or it that something imminent ?

@LPCmedia LPCmedia closed this Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments