[Java][Feign] added 'feignHttpClient' configOption and support for ap…#5715
[Java][Feign] added 'feignHttpClient' configOption and support for ap…#5715gaetPax wants to merge 5 commits intoOpenAPITools:masterfrom
Conversation
…ache feign httpClient (OpenAPITools#5709)
|
@gaetPax thanks for the PR. Please ping me via https://join.slack.com/t/openapi-generator/shared_invite/enQtNzAyNDMyOTU0OTE1LTY5ZDBiNDI5NzI5ZjQ1Y2E5OWVjMjZkYzY1ZGM2MWQ4YWFjMzcyNDY5MGI4NjQxNDBiMTlmZTc5NjY2ZTQ5MGM on how to move this PR forward. |
|
@gaetPax as discussed, please resolve the merge conflicts when you've time. Then we'll review and merge this PR accordingly. |
|
@gaetPax may I know if you've time to resolve the merge conflicts so that we can include this change in the upcoming 5.0.0-beta3 release? |
|
Hi @wing328 , I will try to do it today |
# Conflicts: # modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/JavaClientCodegen.java # modules/openapi-generator/src/main/resources/Java/libraries/feign/build.sbt.mustache
# Conflicts: # modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/JavaClientCodegen.java # modules/openapi-generator/src/main/resources/Java/libraries/feign/build.gradle.mustache # modules/openapi-generator/src/main/resources/Java/libraries/feign/build.sbt.mustache # modules/openapi-generator/src/main/resources/Java/libraries/feign/pom.mustache
|
@gaetPax can you please resolve merge conflicts when you've time? Then please notify me via email in my Github profile to have it reviewed sooner. Thank you. |
|
Support to better HttpClient has been added by #8484 which sets OkHttp as the default feign client, which should be the most complete one (even better than ApacheHttpClient) and capable to handle most of the use cases. |
2 participants
#5709
Added 'feignHttpClient' configOption and support for apache feign httpClient.
Support for other feign httpClient modules can be easily added with same option.