[Java] parameterize formParams#5784
Merged
wing328 merged 15 commits intoOpenAPITools:masterfrom Aug 12, 2020
Merged
Conversation
Contributor
Author
|
Can someone with permission please re-try the failed checks |
…-formParams # Conflicts: # modules/openapi-generator/src/main/resources/Java/libraries/resttemplate/pom.mustache # samples/client/petstore/java/resttemplate-withXml/pom.xml # samples/client/petstore/java/resttemplate/pom.xml
Contributor
Author
|
@wing328 could you take a look at this one too? |
Member
|
@jonfreedman can you please resolve the merge conflicts when you've time? I'll then review and merge accordingly. |
…-formParams # Conflicts: # modules/openapi-generator/src/main/resources/Java/libraries/resttemplate/api.mustache
Contributor
Author
|
I did a merge, looks like all the scripts to re-generate clients have been removed? |
Contributor
Author
|
Ok I think we are there now, please take a look at the review |
Contributor
Author
|
As you can see from my final commit, whilst it's possible to re-generate samples on windows that causes the CircleCI build to fail - the path separators in each FILES listing need to be |
wing328
approved these changes
Aug 12, 2020
Member
wing328
left a comment
wing328
left a comment
There was a problem hiding this comment.
LGTM. Sorry for the delay in reviewing as there're too many PRs to this repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #5782
Fixes errorprone compiler warnings in generated code due to use of raw MultiValueMap type. Due to generic type parameter issues with Spring's MultiValueMap I have updated the Spring dependencies to the latest 5.2.5.RELEASE version in order to pick up the
addAllmethod although any version >= 5.0.0.RELEASE should work fine.PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @bkabrda