Skip to content

[c-sharp] Fix default values with discriminator #6232

Closed
tomelfring wants to merge 5 commits intoOpenAPITools:masterfrom
tomelfring:bugfix/6225
Closed

[c-sharp] Fix default values with discriminator #6232
tomelfring wants to merge 5 commits intoOpenAPITools:masterfrom
tomelfring:bugfix/6225

Conversation

@tomelfring
Copy link
Contributor

@tomelfring tomelfring commented May 9, 2020

Fixes a part of #6225, where the default values aren't registered correctly due to a mismatch in comparing between name and baseName in the class CSharpClientCodegen.java.

Chosen for comparing name because that's the value used more in the same file.

Testcase is already in the samplefiles at:
samples/client/petstore/csharp/OpenAPIClient/src/Org.OpenAPITools/Model/Cat.cs
The default value of className is now set to "Cat" instead of default(string).

Additional testcase is provided in #6225.

To fix #6225

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@mandrean (2017/08), @jimschubert (2017/09) ❤️ @frankyjuang (2019/09) @shibayan (2020/02)

@wing328 wing328 added this to the 5.0.0 milestone Jul 17, 2020
@wing328 wing328 changed the title [c-sharp] Fix #6225 default values with discriminator [c-sharp] Fix default values with discriminator Jul 17, 2020
@wing328
Copy link
Member

wing328 commented Aug 26, 2020

Closed via #7296

@tomelfring tomelfring closed this Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [c-sharp] Inconsistency in default values discriminator

2 participants