[Java] Add add constructor to BYO OkHttpClient#6401
Merged
wing328 merged 3 commits intoOpenAPITools:masterfrom Jun 15, 2020
Merged
[Java] Add add constructor to BYO OkHttpClient#6401wing328 merged 3 commits intoOpenAPITools:masterfrom
wing328 merged 3 commits intoOpenAPITools:masterfrom
Conversation
Contributor
Author
|
@wing328 Any suggestions on what else is required to get this in and/or feedback would be greatly appreciated! |
1d63ab5 to
3c2c4bd
Compare
3c2c4bd to
b28d720
Compare
wing328
approved these changes
Jun 15, 2020
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intention of this change is to allow someone to supply their own
OkHttpClientto theApiClientin the event that they don't want to pay the price for creating a new client even when if they're going tosetHttpClient.A specific example of this is if you have multiple
ApiClients(e.g. imagine a user service and an avatar service) which have different API contracts but could share the same DNS/caching/resiliency settings etc...I appreciate that this could be solved with a custom template but this felt useful enough to contribute.
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.