Skip to content

fix for the issue model import statement is missing in generated api class#6486

Closed
ngp-star wants to merge 4 commits intoOpenAPITools:masterfrom
ngp-star:schematest
Closed

fix for the issue model import statement is missing in generated api class#6486
ngp-star wants to merge 4 commits intoOpenAPITools:masterfrom
ngp-star:schematest

Conversation

@ngp-star
Copy link
Contributor

@ngp-star ngp-star commented May 29, 2020

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

fix for the issue #6484
PR is against the master branch.

@macjohnny macjohnny requested a review from jmini May 29, 2020 10:58
@ngp-star ngp-star force-pushed the schematest branch 2 times, most recently from e1444e7 to 9cb537b Compare May 31, 2020 07:04
@ngp-star
Copy link
Contributor Author

ngp-star commented Jun 5, 2020

@jmini
is there any updates on this PR?

@wing328
Copy link
Member

wing328 commented Jun 15, 2020

@ngp-star looks like the code/change is not indented. Can you please fix it using 4-space for indentation?

@wing328 wing328 added this to the 5.0.0 milestone Jun 15, 2020
@ngp-star ngp-star force-pushed the schematest branch 2 times, most recently from f9e0f15 to ba47167 Compare June 15, 2020 06:41
ngp added 3 commits June 15, 2020 12:42
fix for the issue facing spec invlolving arrayschema structure with ref
removing the changes as this changes corrospond to different PR

fixing checkstyle errors

fixing checkstyle errors

fixing checkstyle errors
@ngp-star
Copy link
Contributor Author

@wing328
chnages are made but in
ci/circleci: build phase I am getting the following error
no changes added to commit (use "git add" and/or "git commit -a")
Please run 'bin/utils/ensure-up-to-date' locally and commit changes (UNCOMMITTED CHANGES ERROR)
even I have made commit latest code by using git pull --rebase upstream master to the created branch schematest.
could you please suggest any options for it?

@ngp-star
Copy link
Contributor Author

ngp-star commented Jun 16, 2020

@wing328 I have moved this PR to different new PR by creating new branch newmaster
as in this PR ci/circleci: build phase is failed i have created new branch and cloned latest code on top of it I have raised the PR
new PR: #6676
fixed checkstyle issues as well on the new PR can you please review the same.?

@ngp-star
Copy link
Contributor Author

@wing328
is there any updates on this PR?

@wing328
Copy link
Member

wing328 commented Jun 29, 2020

Duplicate of #6676

@wing328 wing328 marked this as a duplicate of #6676 Jun 29, 2020
@wing328 wing328 closed this Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants