Skip to content

Remove jacoco from pom.xml#6558

Merged
wing328 merged 5 commits intomasterfrom
pom-cleanup
Jun 12, 2020
Merged

Remove jacoco from pom.xml#6558
wing328 merged 5 commits intomasterfrom
pom-cleanup

Conversation

@wing328
Copy link
Member

@wing328 wing328 commented Jun 5, 2020

To fix #6443. A user has confirmed it's fixed locally in his machine with this fix.

cc @OpenAPITools/generator-core-team

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328 wing328 added the WIP Work in Progress label Jun 5, 2020
This reverts commit d97fc23.
@wing328 wing328 removed the WIP Work in Progress label Jun 6, 2020
@wing328 wing328 added this to the 5.0.0 milestone Jun 6, 2020
@jimschubert
Copy link
Member

Can we put this under a profile instead? This will cause us to lose coverage details in Sonar.

@jimschubert
Copy link
Member

Another option would be for us to set -Djacoco.skip=true in the docker script.

@wing328
Copy link
Member Author

wing328 commented Jun 12, 2020

Done.

@wing328 wing328 merged commit e2e83fc into master Jun 12, 2020
@wing328 wing328 deleted the pom-cleanup branch June 12, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Description './run_in_docker.sh mvn package' fails

2 participants