Use supplied packageName instead of hardcoded#6561
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Jun 15, 2020
Katur7:patch-1
Merged
Use supplied packageName instead of hardcoded#6561wing328 merged 1 commit intoOpenAPITools:masterfrom Katur7:patch-1
wing328 merged 1 commit intoOpenAPITools:masterfrom
Katur7:patch-1
Conversation
Hardcoding open_api_utils there breaks this package if packageName option is used for generating the server code
Member
|
@Katur7 thanks for the PR, which looks good to me. I'll merge over the weekend if no one has further questions/feedback. |
Contributor
Author
|
Sounds good :) |
Contributor
Author
|
@wing328, Hi, is there anything I can do to help getting this merged? |
Member
|
@Katur7 nope, just merged. Sorry for the delay. Thanks again for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardcoding open_api_utils there breaks this package if packageName option is used for generating the server code.
Use the provided {{packageName}} template variable the same as it is used in the rest of the file.
The samples do not change when using the default packageName.
CC erlang technical committe
@tsloughter @jfacorro @robertoaloi
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.