Fix table layout for additionalProperties property#6563
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Jun 15, 2020
Merged
Fix table layout for additionalProperties property#6563wing328 merged 1 commit intoOpenAPITools:masterfrom
wing328 merged 1 commit intoOpenAPITools:masterfrom
Conversation
Contributor
Author
|
Note, the documentation between the description and the values duplicates a lot. Another helpful fix might be remove the duplication. I didn't feel familiar enough to start rewriting the documentation but if that sounds good I'll update the PR to remove the duplication. |
Member
|
@neclimdul thanks for the fix. Sounds good to me. Looking forward to another PR from you to further improve the documentation 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated documentation for
disallowAdditionalPropertiesIfNotPresentdoesn't work correctly because the markdown generator makes very simple tables that don't support new lines. This might be fixed with a more advanced generator but the simplest fix is just to not use the new line for now.PR checklist
master,4.3.x,5.0.x. Default:master.