Skip to content

Fix Basic Bearer auth examples for HTML2 Docs#6579

Merged
wing328 merged 4 commits intoOpenAPITools:masterfrom
l0gicgate:FixBasicBearerHTML2Docs
Jun 10, 2020
Merged

Fix Basic Bearer auth examples for HTML2 Docs#6579
wing328 merged 4 commits intoOpenAPITools:masterfrom
l0gicgate:FixBasicBearerHTML2Docs

Conversation

@l0gicgate
Copy link
Contributor

There were quite a few bugs with all the code examples for the HTML2 docs, it fixes all of them except Rust and Android because I'm unqualified with those languages.

The example templates are now all uniform following the same template patterns.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328
Copy link
Member

wing328 commented Jun 10, 2020

@l0gicgate thanks for the fix. We'll merge it and later see if other contributors can help review and fix Rust, Android code sample.

@wing328 wing328 merged commit a014915 into OpenAPITools:master Jun 10, 2020
@wing328 wing328 added this to the 5.0.0 milestone Jun 10, 2020
@billisonline
Copy link

Very excited to see this fix. I was about to report the same issue. Does anyone know when this will make it into a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants