[Python] Additional properties with array types#6594
Conversation
...petstore/python-experimental/petstore_api/model/additional_properties_with_array_of_enums.py
Show resolved
Hide resolved
samples/openapi3/client/petstore/python-experimental/petstore_api/api/fake_api.py
Outdated
Show resolved
Hide resolved
samples/openapi3/client/petstore/python-experimental/petstore_api/models/__init__.py
Show resolved
Hide resolved
…al/additional-properties-array-enum
|
Can you please review this fix @taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11) @tomplus (2018/10) @Jyhess (2019/01) @arun-nalla (2019/11) @spacether (2019/11)? |
…al/additional-properties-array-enum
| <tr><td> 200 </td><td> Got object with additional properties with array of enums </td><td> - </td></tr> | ||
| </table> | ||
| */ | ||
| public Map<String, List<EnumClass>> getAdditionalPropertiesWithArrayOfEnums() throws ApiException { |
There was a problem hiding this comment.
It looks like Java is suffering the same issue with missing import and not using named class for mapping.
@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @bkabrda (2020/01)
There was a problem hiding this comment.
Thank you for the PR. The python changes look good.
@jirikuncar It looks like the java changes are causing CI errors, happy to wait for fixes or break out the java work as a separate PR.
What do you want to do here?
|
@spacether I would prefer to have the Java fix in separate PR. |
That sounds great. Can you extract the Java update into a separate PR and we can move forward with merging this fix in for python-experimental here? |
|
@spacether I have changed only python related files. Why is the Java generated code changed? |
Hmm it looks like it is because the yaml file is also used by jersey-2 :( |
…al/additional-properties-array-enum
|
@spacether @jimschubert I have created a separate specification for Java. |
|
@spacether |
spacether
left a comment
spacether
left a comment
There was a problem hiding this comment.
Looks good. Thank you for the PR!
jirikuncar
deleted the
python-experimental/additional-properties-array-enum
branch
3 participants
Describes issue with
additionalPropertieswitharraytypes.PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.