Skip to content

[Python] Update docstring and fix a typo#6612

Merged
spacether merged 3 commits intoOpenAPITools:masterfrom
jirikuncar:patch-1
Jun 11, 2020
Merged

[Python] Update docstring and fix a typo#6612
spacether merged 3 commits intoOpenAPITools:masterfrom
jirikuncar:patch-1

Conversation

@jirikuncar
Copy link
Contributor

@jirikuncar jirikuncar commented Jun 10, 2020

It would be nice if the CI automatically updated the generated packages as this change was done through GitHub UI.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

--
@taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11) @tomplus (2018/10) @Jyhess (2019/01) @arun-nalla (2019/11) @spacether (2019/11)

@spacether
Copy link
Contributor

Thanks for the PR.
Can you run bin/ensure-up-to-date? There are two files that will be updated when you run that; after you do it circleCI tests will pass.

Copy link
Contributor

@spacether spacether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you for the PR!

@spacether spacether merged commit ebcce67 into OpenAPITools:master Jun 11, 2020
@wing328 wing328 added this to the 5.0.0 milestone Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants