Conversation
5 tasks
Contributor
|
@wing328 21 hours for review, really? 😄 |
Contributor
|
Now build does compile, don't know why it didn't work. There are changes in Slim4 samples folder like: $ git diff samples/server/petstore/php-slim4/lib/SlimRouter.php
diff --git a/samples/server/petstore/php-slim4/lib/SlimRouter.php b/samples/server/petstore/php-slim4/lib/SlimRouter.php
index 4588e17fd5..6052fa0b97 100644
--- a/samples/server/petstore/php-slim4/lib/SlimRouter.php
+++ b/samples/server/petstore/php-slim4/lib/SlimRouter.php
@@ -61,7 +61,7 @@ class SlimRouter
'userClassname' => 'AnotherFakeApi',
'operationId' => 'call123TestSpecialTags',
'responses' => [
- 'default' => [
+ '200' => [
'code' => 200,
'message' => 'successful operation',
'jsonSchema' => '{ |
Member
Author
|
@ybelenko There was an issue with So the Slim router must have the |
Contributor
Not really, but it helpfull for Mock feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
isDefaultmustache tag in the responsewhich impacts the following generators and I've updated the template accordingly:
cc @OpenAPITools/generator-core-team
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.master