Conversation
Contributor
|
@wing328 Did you run unit tests? |
Member
Author
|
I didn't run it locally. The tests are run by the CI: https://github.com/OpenAPITools/openapi-generator/pull/6722/files#diff-600376dffeb79835ede4a0b285078036R1196 |
ybelenko
approved these changes
Jun 22, 2020
Contributor
ybelenko
left a comment
ybelenko
left a comment
There was a problem hiding this comment.
Checked locally under samples/client/petstore/php/OpenAPIClient-php:
$ vendor/bin/phpunit tests
PHPUnit 8.5.5 by Sebastian Bergmann and contributors.
................................................................. 65 / 73 ( 89%)
........ 73 / 73 (100%)
Time: 10.25 seconds, Memory: 10.00 MB
OK (73 tests, 348 assertions)Btw, it's weird that samples/client/petstore/php/OpenAPIClient-php/tests folder isn't autogenerated, we just store it next to source code for testing while user doesn't have it.
Member
Author
|
@ybelenko as discussed these tests are for Petstore only but we won't auto-generate these files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate PHP client samples to use OAS v3 spec
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.mastercc @jebentier (2017/07), @dkarlovi (2017/07), @mandrean (2017/08), @jfastnacht (2017/09), @ackintosh (2017/09) ❤️, @ybelenko (2018/07), @renepardon (2018/12)